[Bug/Exploit] Inventory swapping can be used to bypass item restrictions

Igneous

Current behaviour: It's possible to bypass certain item restrictions by entering the inventory screen, using a consumable item (such as a potion), and then swapping into the consumable's inventory slot a class-restricted item while the game is still paused. Leaving the inventory screen and unpausing the game will then result in the character using the class-restricted item, instead.

Suggested behaviour: Using a consumable item and then swapping other items into the consumable's inventory slot should result in the item use being cancelled.

Steps to reproduce: Create a thief and spawn several items through the use of the console — e.g., Potions of Healing (POTN08), Potions of Invulnerability (POTN11), and scrolls of Protection from Evil (SCRL3H). In the inventory screen, right-click on one of the healing potions and click 'Drink Potion.' Swap one of the other items into the healing potions' inventory slot, return to the game screen, unpause, and observe.

Games affected: BG2, BGEE.

Notes: This bug doesn't affect BG1 at all, AFAICT. Using a potion while the aura is still clogged from a round action and then hastily swapping in a class-restricted item still results in the potion being used (from its new inventory slot).

ScottBrooks

I've fixed this now, you can no longer drink a potion, swap the item in the space and have it be used instead of the potion

Igneous

Confirmed fixed. Using a potion and swapping inventory slots with a class-restricted item results only in the character avatar returning to the 'ready' position. This age-old exploit has been officially quashed.

William_Imm

Effectively, this should also fix the early mass-money trick, which is basically the same thing, except it is done twice, and the item is a gem. When done correctly, this results in a crap-ton of gems which can be sold for big profits, even early in the game.

SpaceInvader

Hard times for speedrunners