[(BG1, BG2) Request] Add extra 1/2 APR to Grand Mastery (0824)

Igneous

Current: Since BGEE is using BG1's proficiency tables, there isn't that much point to Fighters investing past Mastery, at the moment. The most substantial bonuses come at two and three pips, and all that is to be gained from the last two ranks is a total +2 damage and -3 speed factor.

Requested: As per PnP and BG1's manual, re-instate the extra 1/2 APR to Grand Mastery, to provide a nice bonus for investing five pips in the chosen weapon.

Games affected: BG1, BG2, BGEE.

I've attached a modified, tested copy of WSPATCK.2DA containing the changes. Feel free to use, if you're interested.

AndreaColombo

IIRC, this issue has been fixed. I summon @SethDavis to confirm or deny.

SethDavis

I seem to recall this being handled but not by me. I'll see if I can find it somewhere.

SethDavis

Potentially fixed - WeiDU horribly mangled the 2DA line that I modified, but everything seems to work now. This terrifying A level bug can finally be laid to rest!

Wisp

@SethDavis
Was that with or without PRETTY_PRINT_2DA?

SethDavis

@Wisp - I never knew such a thing existed O_O. I just did a copy_existing and set_2da_entry

Tanthalas

@SethDavis

I think this one didn't make it either.

SethDavis

@Tanthalas - ack, thought I beat you to this one

AndreaColombo

@SethDavis - could you please confirm that the following table is now accurate for BG:EE? I need to fix the dialog.tlk file accordingly.

Proficiency Slot Table:
1 slot: none
2 slots: +1 to hit, +2 to damage, an extra half attack.
3 slots: +3 to hit, +3 to damage, an extra half attack.
4 slots: +3 to hit, +4 to damage, an extra half attack. -1 to speed 
5 slots: +3 to hit, +5 to damage, an extra half attack. -3 to speed

Wisp

@AndreaColombo
It is accurate at the present time.

Tanthalas

@AndreaColombo, @Wisp

If this fix gets in the next build and doesn't break anything, 5 stars is supposed to grant an extra 1/2 attack.

AndreaColombo

Make sure you let me know if it does, then ('cause I might totally miss it)

Tanthalas

Confirmed Fixed in Build 0829

A level 3 Fighter with 5 points in Quarterstaff gets two attacks.
A level 3 Fighter with 4 points in Quarterstaff gets 3/2 attacks.

AndreaColombo

All right, I'll change the description of the 5 slots to "one extra attack".

Do you think I should add "per round" in every string for the sake of clarity?

Tanthalas

@AndreaColombo
Yeah, I think you should add the per round thing.

AndreaColombo

This is what the table looks like now:

Proficiency Slot Table:
1 slot: none
2 slots: +1 to hit, +2 to damage, an extra half attack per round.
3 slots: +3 to hit, +3 to damage, an extra half attack per round.
4 slots: +3 to hit, +4 to damage, an extra half attack per round, -1 to Speed Factor.
5 slots: +3 to hit, +5 to damage, one extra attack per round, -3 to Speed Factor.

Strref #24315 for those wondering.

Bhryaen

@AndreaColombo
I think it's supposed to still say "an extra half attack per round," no? That was what @Igneous was mentioning in the OP. What @Tanthalas was mentioning was:
4 pips = 1.5 APR
5 pips = 2 APR

In other words, it's only an extra half-attack. The "per round" is good though. [snip]

AndreaColombo

Grand Mastery adds one extra half attack compared to High Mastery, but that's not how the table works Notice how every line states "one extra half attack per round". They do not add up, it's always just one extra half attack per round compare to being merely proficient with the weapon. The same applies to Grand Mastery, which is why I changed the text to one extra attack per round.

Bhryaen

@AndreaColombo
Damn... totally missed that... I expected it to chart an extra 2 APR by 5 pips... Then nevermind :-P Carry on!

Bhryaen

And... Confirmed Fixed:

3rd lvl fighter wielding a longsword:

PIPs in
Longsword     APR
        1       1
        2     1.5
        3     1.5
        4     1.5
        5       2

Good thing the CharGen fighter mastery isn't fixed yet- made this easier to test...

Son_of_Imoen

AndreaColombo said:

This is what the table looks like now:

Proficiency Slot Table:
1 slot: none
2 slots: +1 to hit, +2 to damage, an extra half attack per round.
3 slots: +3 to hit, +3 to damage, an extra half attack per round.
4 slots: +3 to hit, +4 to damage, an extra half attack per round, -1 to Speed Factor.
5 slots: +3 to hit, +5 to damage, one extra attack per round, -3 to Speed Factor.

Strref #24315 for those wondering.

Wow, lovely! I didn't know this information whas available that early. I just found out!

drjekl

So to confirm, grand mastery for BGEE will be the unnerfed grand mastery that provides an extra 1/2 attack?

Tanthalas

@drjekl

Yes.

drjekl

Any word on whether unnerfed grand mastery will also be in BGEE 2?

Tanthalas

@drjekl

Should be, I see no point in removing it.