[(BG2, BGEE) BUG] Weapon speed corrections (0813)

CamDawg

A pair of mismatches between weapon descriptions and their actual speed:

• Staff (staf04) should have speed 4 per descript
• Staff of striking (staf05) should have speed 1 per descript

CamDawg

Well, if I would've known we could just post WeiDU code for fixes...

// weapon speed fixes
COPY_EXISTING ~staf04.itm~ ~override~ // generic staff
  READ_LONG  0x64 "abil_off" ELSE 0
  READ_SHORT 0x68 "abil_num" ELSE 0
  FOR (index = 0 ; index < abil_num ; index = index + 1) BEGIN
    READ_SHORT ("%abil_off%" +        (0x38 * "%index%")) "type"
    PATCH_IF (("%type%" = 1) OR ("%type%" = 2) OR ("%type%" = 4)) BEGIN // melee, ranged, launcher
      WRITE_SHORT ("%abil_off%" + 0x12 + (0x38 * "%index%")) 4
    END
  END
  BUT_ONLY_IF_IT_CHANGES

// weapon speed fixes
COPY_EXISTING ~staf05.itm~  ~override~ // staff of striking
  READ_LONG  0x64 "abil_off"
  READ_SHORT 0x68 "abil_num"
  FOR (index = 0 ; index < abil_num ; index = index + 1) BEGIN
    READ_SHORT ("%abil_off%" +        (0x38 * "%index%")) "type"
    PATCH_IF (("%type%" = 1) OR ("%type%" = 2) OR ("%type%" = 4)) BEGIN // melee, ranged, launcher
      WRITE_SHORT ("%abil_off%" + 0x12 + (0x38 * "%index%")) 1
    END
  END
  BUT_ONLY_IF_IT_CHANGES

SethDavis

Potentially fixed - @CamDawg 's fix has been applied

Balquo

Fixed.

Bhryaen

Confirmed Fixed

STAF04- Speed 4
STAF05- Speed 1

CamDawg

I'm re-opening this topic for a few more fixes found by Wisp that need fixin' in BGEE:

//Comprehensive batch of weapon-speed fixes (Wisp)
ACTION_CLEAR_ARRAY fl#speed_item
ACTION_DEFINE_ASSOCIATIVE_ARRAY fl#speed_item BEGIN
  AX1H07   => 7  //Bala's Axe
  SPER03   => 6  //Spear +3, Backbiter
  SW2H03   => 10 //Cursed Berserking Sword +3
END

ACTION_PHP_EACH fl#speed_item AS item => speed BEGIN
  ACTION_IF FILE_EXISTS_IN_GAME "%item%.itm" BEGIN
    COPY_EXISTING "%item%.itm" override
      READ_LONG 0x64 ao
      FOR (i=0;i

AndreaColombo

I'll drop @SethDavis's name to make him aware.

SethDavis

Potentially fixed - @CamDawg 's fix has been applied (after wondering why the forums didn't like his FOR loop)

Tanthalas

Confirmed Fixed In Build 0815

I checked these items in NI and

AX1H07 had speed 7
SPER03 had speed 6
SW2H03 had speed 10

Cuv

Confirmed also with NI build 0815