[(BG1, BG2) BUG] Oil of fiery burning

CamDawg

The oil of fiery burning descript says it causes 5d6 damage (save for half) but inexplicably causes 3d6 + 3d4 (save against 3d4). Despite being thrown, it says 'gulp!' over the user. Finally, power levels on some of the effects are wrong, meaning it could potentially be blocked by magical protections.

// thrown oil of fiery burning shouldn't say 'gulp!', fix power levels
// oil of fiery burning damage incorrect
COPY_EXISTING ~potn13.itm~ ~override~
  LAUNCH_PATCH_FUNCTION ~DELETE_ITEM_EFFECT~ INT_VAR
    opcode_to_delete = "139" // kills 'gulp' effect
    END
  READ_LONG   0x64 "abil_off"
  READ_SHORT  0x68 "abil_num"
  READ_LONG   0x6a "fx_off"
  FOR (index = 0 ; index < abil_num ; index = index + 1) BEGIN // cycle thru abilities
    READ_SHORT  (0x1e + "%abil_off%" + ("%index%" * 0x38)) "abil_fx_num"
    READ_SHORT  (0x20 + "%abil_off%" + ("%index%" * 0x38)) "abil_fx_idx"
    FOR (index2 = 0 ; index2 < abil_fx_num ; index2 = index2 + 1) BEGIN
      READ_BYTE  ("%fx_off%" +        (("%abil_fx_idx%" + "%index2%") * 0x30)) "opcode"
      WRITE_BYTE ("%fx_off%" + 0x03 + (("%abil_fx_idx%" + "%index2%") * 0x30)) 0 // should bypass spell protections
      PATCH_IF ("%opcode%" = 12) BEGIN // as long as we're here, fix duration
        READ_LONG  ("%fx_off%" + 0x24 + (("%abil_fx_idx%" + "%index2%") * 0x30)) "save"
        PATCH_IF ("%save%" = 0) BEGIN // if not subject to save
          WRITE_LONG  ("%fx_off%" + 0x1c + (("%abil_fx_idx%" + "%index2%") * 0x30)) 2 // two rolls...
          WRITE_LONG  ("%fx_off%" + 0x20 + (("%abil_fx_idx%" + "%index2%") * 0x30)) 6 // of 6-sided die
        END
      END
    END
  END
  BUT_ONLY_IF_IT_CHANGES

Tanthalas

I've always interpreted that 'gulp!' as "I hope I don't kill someone in my party with this!"

CamDawg

Original code wasn't fixing the damage issue; working code has been updated in the OP.

SethDavis

Potentially fixed - @CamDawg 's code has been applied

Avenger_teambg

NYAH. You had to give such an effect order that dltcep dies on this item now. Gotta sort this out.
[edit]
The file is larger than it should (4 effects) and has a dead effect in the feat blocks.

Avenger_teambg

Here is a fixed version.

[edit] this might have been a problem with my update method (kept old release before updating, beamdog writes over files, preserving old file size) So, a non issue.

Bhryaen

The oil of fiery burning descript says it causes 5d6 damage (save for half) but inexplicably causes 3d6 + 3d4 (save against 3d4). Despite being thrown, it says 'gulp!' over the user. Finally, power levels on some of the effects are wrong, meaning it could potentially be blocked by magical protections.

Confirmed Fixed:
1. 'Gulp' display string removed.
2. vBG1 was 3d4 (no save), 3d6 (save v breath weapon). BGEE now has 2d6 (no save), 3d6 (save v breath weapon).
3. All effects now at Power = 0.

I can't confirm @Avenger_teambg's findings- definitely only 3 Effects for BGEE (now)- so maybe all ok?

Avenger_teambg

Beamdog ate my file, no problem after a full update.