[(BGEE, BG1) restoration] Algernon's cloak has its own artwork

CamDawg

Currently Algernon's cloak is using the graphics for the nymph cloak, but it has its own set of artwork. This will restore it:

// restore algernon's graphics
COPY_EXISTING ~clck08.itm~ ~override~
  WRITE_ASCII 0x3a ~iclck08~ #8 // inventory icon
  WRITE_ASCII 0x58 ~cclck08~ #8 // inventory icon
  READ_LONG  0x64 "abil_off"
  READ_SHORT 0x68 "abil_num"
  WHILE ("%abil_num%" > 0) BEGIN
    SET "abil_num" = ("%abil_num%" - 1)
    READ_BYTE ("%abil_off%" + (0x38 * "%abil_num%")) "abil_type"
    PATCH_IF ("%abil_type%" = 3) BEGIN
      WRITE_ASCII ("%abil_off%" + 0x04 + (0x38 * "%abil_num%")) ~iclck08~ #8
    END
  END
  BUT_ONLY_IF_IT_CHANGES

Bhryaen

Ooh, this sounds great...

AndreaColombo

Please do! I have never seen this cloak's actual artwork (I wasn't even aware it had dedicated art until I read CamDawg's post) so I'm quite curious now!

Coriander

I'll add this.

Nathan

Verified, this has been integrated internally and should be present in the next build.

Avenger_teambg

nevermind (i see cclck08 is already there)

Balquo

@CamDawg Excuse my ignorance but what is the difference between the OP code and this:

  COPY_EXISTING ~clck08.itm~ ~override~
  WRITE_ASCII 0x58 ~cclck08~
  BUT_ONLY_IF_IT_CHANGES

The reason I ask is because I'm writing up a bunch of fixes for some other items issues I've found.

CamDawg

@Balquo
The OP code is making two more changes--it's writing in cclk08 as the inventory icon (the large drawing on the paper that has the item description) and then it's going through all of the ability headers to change the icon there as well. These are the icons that appear when you use your quick bar to access abilities on an item; without those changes you'd still be seeing the nymph cloak icon for the cloak's charm.

SethDavis

[NVM] I need to start refreshing tabs lol

Bhryaen

That's the intended original artwork?? Well, I like it anyway. Algernon would clearly stand out in a crowd with it... if I hadn't pickpocketed it...

Confirmed Fixed.