@Balquo I also noticed that in areas like AR0400 (zombie farm) you enter quite a ways from the actual area entrance. It's not clear there was any good reason to disorient the player that way. That issue would be a different thread of course, but I wonder if you've noticed this issue in anything more than a couple examples. The only other big example I can think of is AR3800 (lighthouse) where you spawn in on the north side of the map impossibly on the other side of hobgoblin elites with no way out except through them.
@Coriander: Of course I took a random sample and picked the ONE area that was entered incorrectly, so then I had to go through and check the whole thing.
The script drop has been implemented correctly save two minor issues:
AR0164 references two entrances to be changed, there's only one in the area, so the second one is superfluous. (nothing broken, just extra script) AR0808 references one entrance (index 10) to be changed, there's only one so the index should just be 0.
Everything else is fine, and will be in the next build.
@Balquo I don't suppose you have a nice list handy regarding all the areas that were changed and what direction to approach them from to test the new arrival facing? Scouring your code isn't telling me quite enough info for that...
The first one you will find is: PATCH_LOG ~%file%.are - changed facing direction for entrance #%z% from %fd% to 2~
So 2 = SW and it relates to all the areas above it. In this case:AR0102,AR0139,AR0140,AR0165,AR0514,AR2000,AR2600,AR5403
Some areas many have been changed more than once as they may have more than once entrance. What I would do is open up all the area files that are mentioned in the code and see if there facing direction is approptiate.
@Balquo No no, that info I got, but is there some way of determining from that whether you turn SW when entering from, say, the north or west? I mean for checking in-game, knowing which area to start from before entering that area in order to ensure you enter from the facing-direction-changed entrance.
For checking the code alone (easy/ lazy way) I suppose I could just do a BG1-BGEE compare through NI...
Confirmed Fixed
0002- Changed Entrance #0 from S to NE 0101- Changed Entrance #0,#1,#2,#3,#4 from S to #0,#2 SE & #1,#3,#4 NW 0102- Changed Entrance #0,#1 from S to SW, #2,#3 from S to NE 0105- Changed Entrance #2 from NW to W 0108- Changed Entrance #0 from S to NE 0109- Changed Entrance #0,#2 from S to #0 SE & #2 NW 0110- Changed Entrance #0 from W to NW, #1 from E to SE 0111- Changed Entrance #0 from S to N, #1 from NW to NE 0112- Changed Entrance #1 from S to NW 0114- Changed Entrance #0,#1 from S to #0 NE, #1NW 0118- Changed Entrance #0 from S to NE 0119- Changed Entrance #0 from S to NE 0121- Changed Entrance #0 from S to NE 0126- Changed Entrance #0 from S to NW 0130- Changed Entrance #0 from S to NE 0132- Changed Entrance #1 from SW to SE 0138- Changed Entrance #0 from S to E 0139- Changed Entrance #0,#1 from S to SW 0140- Changed Entrance #0,#1 from S to SW 0143- Changed Entrance #0 from S to SE 0146- Changed Entrance #1 from S to NE 0150- Changed Entrance #0 from S to N 0153- Changed Entrance #0,#1,#2 from S to N & #3 from NE to N 0154- Changed Entrance #1 from S to SW 0156- Changed Entrance #0 from S to NE 0162- Changed Entrance #0 from S to NW 0167- Changed Entrance #0,#1 from S to #0 NW, #1 SE 0168- Changed Entrance #0 from S to NW 0169- Changed Entrance #0,#1 from S to #0 NW, #1 SE 0225- Changed Entrance #1,#2 from S to E; #6 from S to N; #7 from S to NE 0226- Changed Entrance #0 from S to SE, #1 from S to E 0304- Changed Entrance #0 from S to NW 0600- Changed Entrance #5 from S to SE 0607- Changed Entrance #0 from S to NW 0700- Changed Entrance #1 from SW to SE 0702- Changed Entrance #0 from S to NE 0703- Changed Entrance #0 from S to N 0705- Changed Entrance #0 from S to NW 0800- Changed Entrance #10 from S to NW 0808- Changed Entrance #0 from S to SE 1102- Changed Entrance #0 from S to NW 1208- Changed Entrance #0 from S to NE 1215- Changed Entrance #0 from S to NW 1404- Changed Entrance #0 from S to NE 1500- Changed Entrance #3 from S to N 1601- Changed Entrance #0 from S to N 1700- Changed Entrance #0 from S to W 2000- Changed Entrance #3 from S to SW 2306- Changed Entrance #0 from S to NE 2619- Changed Entrance #1 from S to SE 3202- Changed Entrance #0 from S to NW 3300- Changed Entrance #33 from S to SE 3301- Changed Entrance #0 from SE to NE 3308- Changed Entrance #1 from E to N 3314- Changed Entrance #0 from N to NW 4000- Changed Entrance #4 from S to NW 4001- Changed Entrance #1 from NE to N 4006- Changed Entrance #0 from SW to SE 4701- Changed Entrance #0 from S to NE 4902- Changed Entrance #0 from S to N 5101- Changed Entrance #0 from S to N 5403- Changed Entrance #1 from S to SW 5405- Changed Entrance #0 from NW to NE
Confirmed Not Fixed (?)
0153- May be a botch, no? Or was this intentional for changing every entrance to facing N?
BG1 and BGEE identical- no changes made: 0155 (listed twice in code- perhaps backwards?) 0163 (listed twice in code- perhaps backwards?) 0164 0165 0166 0170 2600
Perhaps with these, the facing direction was fine but the location forces an avatar shift anyway?
NOTES: I didn't try this in-game at all to determine if the changes actually look right...
Comments
I also noticed that in areas like AR0400 (zombie farm) you enter quite a ways from the actual area entrance. It's not clear there was any good reason to disorient the player that way. That issue would be a different thread of course, but I wonder if you've noticed this issue in anything more than a couple examples. The only other big example I can think of is AR3800 (lighthouse) where you spawn in on the north side of the map impossibly on the other side of hobgoblin elites with no way out except through them.
The script drop has been implemented correctly save two minor issues:
AR0164 references two entrances to be changed, there's only one in the area, so the second one is superfluous. (nothing broken, just extra script)
AR0808 references one entrance (index 10) to be changed, there's only one so the index should just be 0.
Everything else is fine, and will be in the next build.
I don't suppose you have a nice list handy regarding all the areas that were changed and what direction to approach them from to test the new arrival facing? Scouring your code isn't telling me quite enough info for that...
In the code look for PATCH_LOG
The first one you will find is: PATCH_LOG ~%file%.are - changed facing direction for entrance #%z% from %fd% to 2~
So 2 = SW and it relates to all the areas above it. In this case:AR0102,AR0139,AR0140,AR0165,AR0514,AR2000,AR2600,AR5403
Some areas many have been changed more than once as they may have more than once entrance. What I would do is open up all the area files that are mentioned in the code and see if there facing direction is approptiate.
No no, that info I got, but is there some way of determining from that whether you turn SW when entering from, say, the north or west? I mean for checking in-game, knowing which area to start from before entering that area in order to ensure you enter from the facing-direction-changed entrance.
For checking the code alone (easy/ lazy way) I suppose I could just do a BG1-BGEE compare through NI...
Confirmed Fixed
0002- Changed Entrance #0 from S to NE
0101- Changed Entrance #0,#1,#2,#3,#4 from S to #0,#2 SE & #1,#3,#4 NW
0102- Changed Entrance #0,#1 from S to SW, #2,#3 from S to NE
0105- Changed Entrance #2 from NW to W
0108- Changed Entrance #0 from S to NE
0109- Changed Entrance #0,#2 from S to #0 SE & #2 NW
0110- Changed Entrance #0 from W to NW, #1 from E to SE
0111- Changed Entrance #0 from S to N, #1 from NW to NE
0112- Changed Entrance #1 from S to NW
0114- Changed Entrance #0,#1 from S to #0 NE, #1NW
0118- Changed Entrance #0 from S to NE
0119- Changed Entrance #0 from S to NE
0121- Changed Entrance #0 from S to NE
0126- Changed Entrance #0 from S to NW
0130- Changed Entrance #0 from S to NE
0132- Changed Entrance #1 from SW to SE
0138- Changed Entrance #0 from S to E
0139- Changed Entrance #0,#1 from S to SW
0140- Changed Entrance #0,#1 from S to SW
0143- Changed Entrance #0 from S to SE
0146- Changed Entrance #1 from S to NE
0150- Changed Entrance #0 from S to N
0153- Changed Entrance #0,#1,#2 from S to N & #3 from NE to N
0154- Changed Entrance #1 from S to SW
0156- Changed Entrance #0 from S to NE
0162- Changed Entrance #0 from S to NW
0167- Changed Entrance #0,#1 from S to #0 NW, #1 SE
0168- Changed Entrance #0 from S to NW
0169- Changed Entrance #0,#1 from S to #0 NW, #1 SE
0225- Changed Entrance #1,#2 from S to E; #6 from S to N; #7 from S to NE
0226- Changed Entrance #0 from S to SE, #1 from S to E
0304- Changed Entrance #0 from S to NW
0600- Changed Entrance #5 from S to SE
0607- Changed Entrance #0 from S to NW
0700- Changed Entrance #1 from SW to SE
0702- Changed Entrance #0 from S to NE
0703- Changed Entrance #0 from S to N
0705- Changed Entrance #0 from S to NW
0800- Changed Entrance #10 from S to NW
0808- Changed Entrance #0 from S to SE
1102- Changed Entrance #0 from S to NW
1208- Changed Entrance #0 from S to NE
1215- Changed Entrance #0 from S to NW
1404- Changed Entrance #0 from S to NE
1500- Changed Entrance #3 from S to N
1601- Changed Entrance #0 from S to N
1700- Changed Entrance #0 from S to W
2000- Changed Entrance #3 from S to SW
2306- Changed Entrance #0 from S to NE
2619- Changed Entrance #1 from S to SE
3202- Changed Entrance #0 from S to NW
3300- Changed Entrance #33 from S to SE
3301- Changed Entrance #0 from SE to NE
3308- Changed Entrance #1 from E to N
3314- Changed Entrance #0 from N to NW
4000- Changed Entrance #4 from S to NW
4001- Changed Entrance #1 from NE to N
4006- Changed Entrance #0 from SW to SE
4701- Changed Entrance #0 from S to NE
4902- Changed Entrance #0 from S to N
5101- Changed Entrance #0 from S to N
5403- Changed Entrance #1 from S to SW
5405- Changed Entrance #0 from NW to NE
Confirmed Not Fixed (?)
0153- May be a botch, no? Or was this intentional for changing every entrance to facing N?
BG1 and BGEE identical- no changes made:
0155 (listed twice in code- perhaps backwards?)
0163 (listed twice in code- perhaps backwards?)
0164
0165
0166
0170
2600
Perhaps with these, the facing direction was fine but the location forces an avatar shift anyway?
NOTES:
I didn't try this in-game at all to determine if the changes actually look right...
Can't really test this for a bit yet but go ahead and open those areas in game and see if they need changed or not.