[(BGEE, BG2) Bug] Resurrection bugs

CamDawg

If a character dies, the resurrection spells go through the revived character and remove a lot of spells (such as polymorph, spell triggers, etc.). However, due to a typo one of the spells is being missed:

// resurrection(s) trying to remove incorrect spell resource
COPY_EXISTING ~spja01.spl~   ~override~ // harpers call 
              ~sppr504.spl~  ~override~ // raise dead
              ~sppr712.spl~  ~override~ // resurrection
              ~sppr729.spl~  ~override~ // mass raise dead
              ~spwish10.spl~ ~override~ // mass riase dead
  READ_LONG   0x64 "abil_off" ELSE 0
  READ_SHORT  0x68 "abil_num" ELSE 0
  READ_LONG   0x6a "fx_off"   ELSE 0
  FOR (index = 0; index < abil_num; index = index + 1) BEGIN // adjusts fx indices on abilities
    READ_SHORT  ("%abil_off%" + 0x1e + ("%index%" * 0x28)) "abil_fx_num"
    READ_SHORT  ("%abil_off%" + 0x20 + ("%index%" * 0x28)) "abil_fx_idx"
    FOR (index2 = 0 ; index2 < abil_fx_num ; index2 = index2 + 1) BEGIN
      READ_SHORT ("%fx_off%" +        (0x30 * ("%index2%" + "%abil_fx_idx%"))) "opcode"
      READ_ASCII ("%fx_off%" + 0x14 + (0x30 * ("%index2%" + "%abil_fx_idx%"))) "spell"
      PATCH_IF (("%opcode%" = 172) AND ("%spell%" STRING_COMPARE_CASE "spwi126" = 0)) BEGIN
        WRITE_ASCII ("%fx_off%" + 0x14 + (0x30 * ("%index2%" + "%abil_fx_idx%"))) "spin126"
      END
    END
  END
  BUT_ONLY_IF_IT_CHANGES

Coriander

I'm going to add this.

Nathan

Verified, this has been integrated and should be present in the next build.

Avenger_teambg

Confirmed fixed.
Just mentioning, mass raise dead will never work as intended. pre-target won't target all the freshly raised creatures, so it won't be able to remove their spells. But this is not a problem for now as it is part of the wish spell.

Bhryaen

If only multiplayer were working at least well enough to create our own party... Can't test this in-game because SPIN126 is for an Avenger shapeshift (to baby wyvern). No NPCs are Avengers...

Bhryaen

OK, made a scroll (mage heh) which contained the "spell" SPIN126. On casting, Xan became a baby wyvern just fine, attacked a tutor, got killed by Phlydia, his corpse was instantly an elf again, and on rezzing w CTRL-R he was his old desultory self again. Yea.

Just in case that wasn't enough, I also tried Xan again, this time getting clobbered by an OGRE.CRE rather than a Phlydia. And after dying, his corpse again immediately transforming to elf, I used the local Oghma priest to rez Xan. Again- back to elf just fine.

Confirmed Fixed if that was legit.

Avenger_teambg

@Bhryaen nah, that wasn't legit. ctrl-r doesn't even use the changed spells You should probably seen a residue innate after ctrl-r, though. If you saw that, but you didn't see it with temple rez, then it would be legit.

Bhryaen

@Avenger
Well, I did two tests- one with CTRL-R, the other with the Oghma priest in Candlekeep.