[(BG2, BGEE) Bug] Spell failure portrait icons

CamDawg

The divine spells creeping doom, insect swarm and the wild make surge repulsion all cause 100% spell failure, but lack portrait icons to indicate this effect. This patch will add spell failure icons to these spells:

// spell failure effects not accompanied by spell failure icon
COPY_EXISTING ~sppr517.spl~  ~override~ // 100%, no icon
  LAUNCH_PATCH_FUNCTION ~ADD_SPELL_EFFECT~ INT_VAR
    opcode        = 142 // display portrait icon
    target        = 2   // preset target
    power         = 5   // power
    resist_dispel = 1   // dispel/bypass MR
    duration      = 36  // duration
    parameter2    = 83  // icon: spell failure
    END
  BUT_ONLY

// spell failure effects not accompanied by spell failure icon
COPY_EXISTING ~sppr717.spl~  ~override~ // 100%, no icon
  LAUNCH_PATCH_FUNCTION ~ADD_SPELL_EFFECT~ INT_VAR
    opcode        = 142 // display portrait icon
    target        = 2   // preset target
    power         = 7   // power
    resist_dispel = 1   // dispel/bypass MR
    duration      = 18  // duration
    parameter2    = 83  // icon: spell failure
    END
  BUT_ONLY

// spell failure effects not accompanied by spell failure icon
COPY_EXISTING ~spwm128.spl~  ~override~ // 100%, no icon
  LAUNCH_PATCH_FUNCTION ~ADD_SPELL_EFFECT~ INT_VAR
    opcode        = 142 // display portrait icon
    target        = 2   // preset target
    resist_dispel = 0   // dno ispel/bypass MR
    duration      = 60  // duration
    parameter2    = 83  // icon: spell failure
    END
  BUT_ONLY

CamDawg

Rather than spam another thread, I'll just add this here.

The wild mage surge entangle doesn't cause an entangled portrait icon.

// entangle wild surge not setting entangle icon
COPY_EXISTING ~spwm111.spl~ ~override~
  LAUNCH_PATCH_FUNCTION ~ADD_SPELL_EFFECT~ INT_VAR
    opcode        = 142 // display portrait icon
    target        = 2   // preset target
    power         = 1   // power
    resist_dispel = 1   // dispel/bypass MR
    duration      = 60  // duration
    parameter2    = 144 // icon: entangled
    END
  BUT_ONLY

Coriander

I'll put these in.

Nathan

This has been implemented internally, should be in the next build.

Tanthalas

Confirmed Fixed for the Druid Insect Plague.

Can't test Creeping Doom because its a level 7 spell.
Can't test the Wild Surges because of the CC problems for Wild Mages.

Avenger_teambg

Confirmed fixed for spwm111 has the icon set
Ok creeping doom has spell failure icon now.

Tanthalas

After about 50+ wild surges I finally managed to get Entangle.

I can confirm that the Entangle Wild Surge now also shows an Entangle portrait icon.