[(BG2) bug] Color spray

CamDawg

Color spray is supposed to have a range of visual (30 feet) but was set to 15. It was also imposing a save penalty and was not fanning out over 60 degrees, both contrary to its descript.

// color spray fixes - range is wrong, removes undocumented save penalty
COPY_EXISTING ~spin937.spl~ ~override~ // mephit version
              ~spwi105.spl~ ~override~ // regular mage version
  READ_LONG  0x64 "abil_off"
  READ_SHORT 0x68 "abil_num"
  READ_LONG  0x6a "fx_off"
  FOR ("index" = 0; "%index%" < "%abil_num%"; "index" = ("%index%" + 1)) BEGIN // fix existing effects
    WRITE_SHORT ("%abil_off%" + 0x0e + ("%index%" * 0x28)) 30 // corrects range
    READ_SHORT  ("%abil_off%" + 0x1e) "abil_fx_num"
    READ_SHORT  ("%abil_off%" + 0x20) "abil_fx_idx"
    FOR ("index2" = 0; "%index2%" < "%abil_fx_num%"; "index2" = ("%index2%" + 1)) BEGIN
      WRITE_LONG  ("%fx_off%" + 0x28 + (0x30 * ("%abil_fx_idx%" + "%index2%"))) 0 // set save bonus to 0
    END
  END
  BUT_ONLY_IF_IT_CHANGES

// color spray arc fix
COPY_EXISTING ~cspray.pro~ ~override~
  WRITE_SHORT 0x206 256
  BUT_ONLY_IF_IT_CHANGES

KeithS

Adding...

Avenger_teambg

Color spray always starts from the caster (effectively 0 range) and its radius of effect is based on the projectile. Will it ever reach the target with this new range?

Notifying @Nathan so he can test it earlier.

Cuv

I was wondering the same thing... but guess we can report if it doesnt and the change can be reverted (and just change the description)?

Nathan

I'll test this in-game with our build while I'm checking out other stuff and report back if it isn't.

Avenger_teambg

@CamDawg I had to write 426 ('50) in the projectile radius to have effect with '30 as spell range. These distance units are totally messed up. By the way, color spray prints a weird string for me: 10581 ('Ere there, I don't need no armored prats scaring away my friends. Get along, children.)

It is - 'Too high of level for Color Spray' - so, another string bug.

Nathan

As detailed in the other thread, but, I'll put it here - color spray does not reach the full range as other people have noted. Et tu, @CamDawg?

Coriander

@Nathan Are you implying that @CamDawg has stabbed you in the senate?

CamDawg

Yeah, change the cspray.pro to use Avenger_teambg's 426 instead of the 256 and (aside from the string issue) it should now be good to go.

CamDawg

/quickly drops dagger

Nathan

@Coriander, @CamDawg - Ow, right in the senate!

CamDawg

Avenger_teambg

Further beating this undead horse:

You intended to fix the Arc of color spray, but that is 0x224 not 0x206.
You didn't break it much, because 0x206 is the effect radius. 256 is tad small, though it should be the 426 i wrote about.
On the other hand, 60 (0x3c) was correctly set as arc at position 0x224. So the arc need not be touched.

Here is the field break down (as per IELISTER)

0200h AOE section
0200h AOE flags 00000800
0204h Trigger radius 00fa
0206h Effect radius 00fa
0208h Explosion sound
0210h Delay 0009
0212h Animation ID 0000
0214h Projectile ID 0000
0216h Explosion count 01
0217h Explosion type ff
0218h Explosion colour 0043
021ah Another projecti 004f
021ch VVC
0224h Cone width 003c

Avenger_teambg

In @Coriander's terms, this boils down to this snippet:

// color spray distance fix
COPY_EXISTING ~cspray.pro~ ~override~
WRITE_SHORT 0x206 426
BUT_ONLY_IF_IT_CHANGES

SethDavis

Since July?!?!?! ... This has been fixed almost longer than I've been working on bugs....

Potentially fixed - @Avenger_teambg's fix has been added

Avenger_teambg

@SethDavid It is easy to skip over a bug when we just dump it on you And this one was not too important to insist on its fix.

Avenger_teambg

Color spray range confirmed fixed.

Tanthalas

If the thing that's supposed to be fixed is the explosion size, then Confirmed Fixed in build 0924.