[(BGEE, BG2) bug] Confusion

CamDawg

Per its description, victims of confusion should be saving vs. spells at -2. Currently there is no save penalty being imposed.

// confusion (mage) missing -2 save penalty
COPY_EXISTING ~spwi401.spl~ ~override~
  READ_LONG  0x64 "abil_off"
  READ_SHORT 0x68 "abil_num"
  READ_LONG  0x6a "fx_off"
  FOR (index = 0 ; index < abil_num ; index = index + 1) BEGIN // fix existing effects
    READ_SHORT  ("%abil_off%" + 0x1e + (0x28 * "%index%")) "abil_fx_num"
    READ_SHORT  ("%abil_off%" + 0x20 + (0x28 * "%index%")) "abil_fx_idx"
    FOR (index2 = 0 ; index2 < abil_fx_num ; index2 = index2 + 1) BEGIN
      READ_LONG  ("%fx_off%" + 0x24 + (0x30 * ("%abil_fx_idx%" + "%index2%"))) "saves"
      PATCH_IF ("%saves%" != 0) BEGIN // if save allowed
        WRITE_LONG ("%fx_off%" + 0x28 + (0x30 * ("%abil_fx_idx%" + "%index2%"))) 0xfffffffe // should be a -2 penalty
      END
    END
  END
  BUT_ONLY_IF_IT_CHANGES

KeithS

Adding...

Nathan

Verified, this change has been integrated internally and should be present in the next build.

Avenger_teambg

Confirmed fixed. -2 is in all effects.

Bhryaen

I tried to confirm it in-game, maybe didn't do something right...

I created an alternate of the new Resar who has nothing but Confusion spells, checked the Record screen to see that Nexlit the Blue Elf has Save V Spells of 12, CLUA'd in the new Resar, made him mad, he cast Confusion and it worked on Nexlit, I immediately checked the Record and it was still saying Save V Spells 12... Not sure what I did wrong... I then created a new character, totally barren of extras, started with Save V Spells of 11, got Confused, same thing- 11. Maybe it just doesn't show?

Avenger_teambg

The -2 doesn't mean it will damage your saving throw. It means, that when you do your saving throw, there is a penalty for doing that single roll. I don't know if saving throw rolls are displayed ever. Maybe if you turn on all combat feedback.

Tanthalas

Saving throw rolls are only displayed if you succeed I think.

Bhryaen

OK, best I could do- found SPWI401.SPL in the BGEE overrides with NI. All spell effects right down to the sound effects and graphics for all 4 Spell abilities are set to:

"Savetype" = ( Save vs spells(0) )
"Save bonus" = -2

Looks about right...

Confirmed Fixed