[(BGEE, BG2) bug] Farsight

CamDawg

Farsight is supposed to last 3 rds + 1 rd/level but actually lasts 10.333 rds + 1 rd/level.

// mage farsight has wonky durations
COPY_EXISTING ~spwi424.spl~ ~override~
  READ_LONG  0x64 "abil_off"
  READ_SHORT 0x68 "abil_num"
  READ_LONG  0x6a "fx_off"
  FOR (index = 0 ; index < abil_num ; index = index + 1) BEGIN
    READ_SHORT ("%abil_off%" + 0x10 + (0x28 * "%index%")) "level"
    PATCH_IF ("%level%" = 1) BEGIN
      SET "level" = 7
    END
    READ_SHORT ("%abil_off%" + 0x1e + (0x28 * "%index%")) "abil_fx_num"
    READ_SHORT ("%abil_off%" + 0x20 + (0x28 * "%index%")) "abil_fx_idx"
    FOR (index2 = 0 ; index2 < abil_fx_num ; index2 = index2 + 1) BEGIN
      READ_LONG  ("%fx_off%" + 0x0e + (0x30 * ("%abil_fx_idx%" + "%index2%"))) "duration"
      PATCH_IF ("%duration%" > 5) BEGIN // if longer than instant
        WRITE_LONG  ("%fx_off%" + 0x0e + (0x30 * ("%abil_fx_idx%" + "%index2%"))) (6 * (3 + "%level%"))
      END
    END
  END
  BUT_ONLY_IF_IT_CHANGES

KeithS

adding this

Nathan

This has been integrated and should be present in the next build.

Avenger_teambg

confirmed fixed in editor - it didn't disturb effects it shouldn't

Tanthalas

Hmm, I can actually use my stopwatch to test this one too. Tagged for later.

Tanthalas

Is there somewhere I can find the codes for BG2 items? It looks like scrlaq isn't currently in the game.

Tanthalas

Confirmed Fixed.

Ok, I didn't know how to teach this spell to a Mage so I used a Sorcerer instead:

Level 8 -> 66 seconds -> 11 rounds
Level 9 -> 72 seconds -> 12 rounds
Level 10 -> 78 seconds -> 13 rounds

Avenger_teambg

No farsight scroll, yeah. It was scrlaj. Lots of missing scrolls...