[(BGEE, BG2) Bug] Minor Spell Turning (0813)

CamDawg

Minor spell turning is supposed to turn spells of levels 1-4, but was acting a sits big brother and turning spells of levels 1-7.

 // minor spell turning reflecting spells of level 5-7; should only be 1-4
COPY_EXISTING ~spwi522.spl~ ~override~
  LAUNCH_PATCH_FUNCTION ~DELETE_SPELL_EFFECT~ INT_VAR
    opcode_to_delete = 200 // remove  all spell turnings
    END
  READ_SHORT 0x68 "abil_num"
  FOR (index = 1 ; index <= abil_num ; index = index + 1) BEGIN 
    READ_SHORT ("%abil_off%" + 0x10 + (0x28 * ("%index%" - 1))) "level"
    PATCH_IF ("%level%" = 1) BEGIN
      SET "level" = 5
    END
    FOR (index2 = 1 ; index2 < 5 ; index2 = index2 + 1) BEGIN
      LAUNCH_PATCH_FUNCTION ~ADD_SPELL_EFFECT~ INT_VAR
        opcode        = 200              // remove feeblemind
        target        = 1                // self
        power         = 5                // power
        parameter1    = 4                // absorb 4 spells
        parameter2    = "%index2%"       // levels 1-4
        duration      = (18 * "%level%") // 3 rds/level
        header        = "%index%"        // one per header
        resist_dispel = 2                // not dispel/bypass MR
        insert_point  = 0                // add as first effect
        END
    END
  END
  BUT_ONLY_IF_IT_CHANGES</pre>

SethDavis

checking this one in now

Potentially fixed - @CamDawg 's fix has been applied

Avenger_teambg

Confirmed fixed.
@CamDawg did you see SPWI701? Some of those effects contain excess resrefs

Tanthalas

Confirmed Fixed in Build 0815

First I tried seeing if I could confirm this with NI. Then I gave up.

Then I created a Sorcerer in BGEE, leveled him up enough to get level 7 spells. Spawned Neera to use as a test subject and found out that the scroll still isn't in BGEE.

Used NI to get the scroll from vBG2, taught Neera the spell and proceeded to do some testing.

Minor Spell Turning worked on level 1-4 spells, but had no effect on level 5-7 spells.