[(BG2) Bug] Assassin poison

CamDawg

Per the assassin kit description, their poison ability should force a save vs. poison (death). However, it's currently set to save vs. everything--I'm not sure if this means the engine selects the best/worst save or rolls five times, but regardless it's incorrect at present.

The damage for the first round is also incorrect.

// assassin poison should be a save v death, not save v everything
COPY_EXISTING ~SPCL422.EFF~ ~override~
  WRITE_LONG 0x40 0x4 // saving throw vs. death ONLY
  BUT_ONLY_IF_IT_CHANGES

// more assassin poison; damage is incorrect
COPY_EXISTING ~SPCL422A.EFF~ ~override~
  WRITE_LONG 0x1c 0x2 // +2 damage, not 1
  WRITE_LONG 0x20 0x02 // type is incorrect (Nythrun)
  BUT_ONLY_IF_IT_CHANGES

Coriander

I'll drop this in.

Nathan

Verified, this has been integrated internally and should be present in the next build.

Bhryaen

@Coriander
Did @Avenger_teambg's correction get added or does it need another thread?

Avenger_teambg

SPCL422B was not updated.
SPCL422A has no save type now???
SPCL422 is correct

Coriander

@Bhryaen It isn't in. I'll split it.

Avenger_teambg

@Coriander, i think it is easier to just go over them with an editor and see if all fields are set.
Submitting patches is slow. Alternatively i could submit the fixed files, if that's fine?

Actually i think spcl422a is good as it is. So only spcl422b needs a clearing of the saving throw, just like with spcl422a.

Tanthalas

@Coriander

I think this one still has the issues that @Avenger_teambg mentioned.

Avenger_teambg

Just one issue. The saving throw weirdness in spcl422b

Coriander

Blerg.... @KeithS

KeithS

Late to the party, but I've integrated it (I think). Checking it in now.

CamDawg

The description:

- May coat his weapon in poison once per day per 4 levels. The next hit with that weapon will inject the poison into the target, dealing out 1 damage per second for 24 seconds (3 damage for the first 6 seconds). A saving throw vs. poison limits damage to 12 total.

spcl422 does 1 damage per second for 24 seconds. This can be saved against.
spcl422a does 2 damage per second for six seconds, no save.
spcl422b shows the poison icon for 24 seconds, no save.

Damage is fine, but the icons are not. 422b needs a save and we need a non-savable poison icon for the first six seconds.

KeithS

So, just to be sure I'm making the correct tweak here, I've nuked all of saving throws for spcl422b.

Bhryaen

I'm not seeing the SPCL422.EFF call in the SPCL422.SPL, but that's probably my NI's recent detachment from BGEE's format...

Confirmed Still Not Fixed 0907:

SPCL422:
Poison, gets a Save v Paralyze/Poison/Death at Save Bonus +0 and lasts 24 sec at 1 dam.
SPCL422A:
Poison, no save and lasts 6 sec at 2 dam.
SPCL422B:
Display portait icon, no save, lasts 24 sec.

@KeithS
Just need to add the Save v Paralyze/Poison/Death(2) with no bonus for SPCL422B.EFF for this to be done...

KeithS

@Bhryaen Fixed.

Bhryaen

@CamDawg
Uh oh, was I wrong? Do we need an extra non-save Poison icon as well or is that taken care of in the SPL?

Bhryaen

Confirmed Fixed in 0914:

SPCL422.EFF:
Poison, Save v Paralyze/Poison/Death at +0, lasts 24 sec at what appears to be 1 dam... (The 9-5 NI is still coding out that field under Power, but I assume that's the Value field and 01 00 00 00h = 1.)
SPCL422A.EFF:
Poison, No Save, lasts 6 sec at what appears to be 2 dam.
SPCL422B.EFF:
Display portrait icon: Poisoned, Save v Paralyze/Poison/Death at +0, lasts 24 sec.

NOTES:
I totally don't understand this one though... The actual special ability SPCL422.SPL doesn't appear (in NI) to draw on any EFF in any of its spell ability effects at any level, everything handled with Opcode 25 (Poison). Dunno.

Avenger_teambg

@Bhryaen the actual spell is spcl423.
It uses the effects.

Avenger_teambg

I don't know what changed, but the worst thing that can happen is that you don't see the poisoned icon if you save vs poison (part of the poison cannot be saved against).
So i vote to close this.

Bhryaen

we need a non-savable poison icon for the first six seconds.

So I was mistaken and overlooked this crucial detail. @CamDawg will this require a new EFF- SPCL422C.EFF for the first 6 sec? Otherwise this will go out only part-fixed looking like more of a bug than it is.