[Known 18113] AR5400 script blocks mod added content

swit

This code should be changed because it is always true, so it blocks everything below it.

IF
  !Dead("Amnish3")
  !Dead("Amnish3a")
  !Dead("Amnish3b")
  !Global("GuardMinePermission","GLOBAL",1)
THEN
  RESPONSE #100
    TriggerActivation("Door5401",FALSE)
END

IF
  OR(4)
    Dead("Amnish3")
    Dead("Amnish3a")
    Dead("Amnish3b")
    Global("GuardMinePermission","GLOBAL",1)
THEN
  RESPONSE #100
    TriggerActivation("Door5401",TRUE)
END

calling @Avenger_teambg, since he already noticed this back in August 2012. The way it is coded conflicts with many mods.

Erg

Reported also by me here.

I'm currently fixing this myself in one of my (unreleased) mods with the following code:

// Fixing area scripts AR4100.BCS and AR5400.BCS
COPY_EXISTING AR4100.BCS ~override~
              AR5400.BCS ~override~
  PATCH_IF SOURCE_SIZE > 0x34 BEGIN
    DECOMPILE_AND_PATCH BEGIN
      REPLACE_TEXTUALLY CASE_INSENSITIVE EVALUATE_REGEXP ~THEN
\(.*RESPONSE.*\)
\(.*TriggerActivation.+FALSE.+\)~ ~Global("ER_DEACT","%SOURCE_RES%",0)
THEN
\1
SetGlobal("ER_DEACT","%SOURCE_RES%",1)
\2~
      REPLACE_TEXTUALLY CASE_INSENSITIVE EVALUATE_REGEXP ~THEN
\(.*RESPONSE.*\)
\(.*TriggerActivation.+TRUE.+\)~ ~Global("ER_ACT","%SOURCE_RES%",0)
THEN
\1
SetGlobal("ER_ACT","%SOURCE_RES%",1)
\2~
    END
  END
BUT_ONLY_IF_IT_CHANGES