Skip to content

TobEx: 20 (0813)

DanBoulosDanBoulos Member Posts: 146
edited August 2012 in Fixed
Current Behaviour:

Effect #12 “Damage”: hitting someone with magic cold damage does not play a hit sound

Expected Behaviour:

Effect #12 “Damage”: hitting someone with magic cold damage does play a hit sound

Revision:

Add DAMAGE_MAGICCOLD case after DAMAGE_COLD to match DAMAGE_MAGICFIRE and DAMAGE_FIRE
Post edited by Bhryaen on

Comments

  • CadrosCadros Member Posts: 253
    @DanBoulos Am I being silly or are these expected and current behaviours the same?
  • BhryaenBhryaen Member Posts: 2,874
    edited August 2012
    This was a partial success... but not fixed. I just used a Wand of Frost on Mulahey to test (WAND06). This was the result... *ahem* So clearly an audible response... just not exactly... frosty...

    [SNIP]
    Post edited by Bhryaen on
  • IgneousIgneous Member Posts: 368
    edited July 2012
    Confirmed fixed on the magic cold hit sound, I think. I'm a little confused, because in Tutu I couldn't reproduce the lack of magic cold sound effects. @Wisp, do you have any idea to which this TobEx fix refers?

    Test #1: I created several Wand of Frost variations: two based on the BG1 version, and two on the BG2 version. For each pair, one wand used the default projectile animation and the other none. All wands were modified to deal magic cold damage.

    In Tutu: All wands produced cold hit sfx. The cold hit visual effects, however, didn't function on any of the wands.
    In BGEE: All wands successfully produced the cold sfx (more clearly audible) and vfx.

    Test #2: I created a Varscona +2 variation which used magic cold damage.

    In Tutu: As with the wands, the cold sfx played. The cold vfx, on the other hand, didn't play.
    In BGEE: The sword produced the cold sfx (more clearly audible) and the vfx.
    This was a partial success... but not fixed. I just used a Wand of Frost on Mulahey to test (WAND06). This was the result... *ahem* So clearly an audible response... just not exactly... frosty...
    The Agannazar's animation appears to be a separate issue of an erroneous projectile being used for the Wand of Frost (WAND06.ITM).

    Current: 191 Scorcher Ice. (Can't see PRO filename, apologies.)

    Expected: 105 Fireball blue (FIREBTBL.PRO), used in BG1; or 250 New Cone of Cold (CONECOLD.PRO), used in BG2. I'm partial to the BG1 projectile, myself.
  • WispWisp Member Posts: 1,102
    @Igneous
    No, I don't have any additional insights. COLD and MAGIC_COLD sound identical to me in vanilla ToB and ToBEx does not go into any details.
  • SethDavisSethDavis Member Posts: 1,812
    edited July 2012
    @Igneous @Wisp - Very new to WeiDu, but does this look like it would fix WAND06.ITM?

    COPY_EXISTING ~WAND06.ITM~ ~override~
    GET_OFFSET_ARRAY ab_array 0x64 4 0x68 2 0 0 0x38
    WRITE_LONG 0x002a 0x0068
  • WispWisp Member Posts: 1,102
    @SethDavis
    Almost. But after making the array with GET_OFFSET_ARRAY, you need to iterate over it with PHP_EACH and use the result of the array in the where of the write (which should be a short, incidentally).
    Something like this: 

    COPY_EXISTING wand06.itm override
      GET_OFFSET_ARRAY ab_array ITM_V10_HEADERS //ITM_V10_HEADERS is an alternative to "0x64 4 0x68 2 0 0 0x38"
      PHP_EACH ab_array AS int => ab_off BEGIN
        WRITE_SHORT ab_off + 0x2a 0x68
      END
  • SethDavisSethDavis Member Posts: 1,812
    edited July 2012
    @Wisp - Thank you kindly ^^

    [EDIT] Potentially (AND FINALLY!) fixed - the wand now shoots a block of ice
    Post edited by SethDavis on
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    edited August 2012
    Ahh, this is two bugs in one. I was looking into the wand06 and it has no magic cold damage.
    Testing the original bugfix....
    Meanwhile, someone could split this into two?
    1. tobex magic cold sound effect
    2. wand06 wrong projectile. @SethDavis could fix scorcher ice (191) hardcoded projectile to be blue. It is different from the real scorcher projectile (109)
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    1. magic cold sound effect confirmed
    2. wand06 projectile was modified, but the real fix would be to fix scorcher ice (this is rank C). Mostly because the wand's description talks about a column of ice (like the scorcher).
  • SethDavisSethDavis Member Posts: 1,812
    edited August 2012
    Ok, so I can kind of change the colour. I can't just make the same effect blue though. These are what I've figured out how to do so far.

    [SNIP] [SNIP] [SNIP]

    i kind of like the middle one, but it's probably not what you're expecting

    also, the effect is now REALLY long
    Post edited by Bhryaen on
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    edited August 2012
    Huh, wait a moment, i think i can do much better than this :)
    Doesn't scorcher ice (the projectile) use spscoric.bam?
  • SethDavisSethDavis Member Posts: 1,812
    indeed it does good sir
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    edited August 2012
    This looks much better, isn't it

    [SNIP]
    Post edited by Bhryaen on
  • SethDavisSethDavis Member Posts: 1,812
    That portrait for Imoen creeps me out every time I see it....

    But the effect does look pretty good :)
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    SethDavis said:

    That portrait for Imoen creeps me out every time I see it....

    But the effect does look pretty good :)

    That's projectile 191 in tob. When i get my download i'll see what it takes to bring the same to bgee, and report back :)
  • TanthalasTanthalas Member Posts: 6,738
    Yeah, I like Avenger_teambg's ice effect more.
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    edited August 2012
    That is unmodded tob, I have no idea why it isn't the same in bgee. It is one of the hardcoded projectiles.
    Or maybe i did something to it, lol.
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    @SethDavis try this bam. Also, set the projectile to 191 if you haven't done yet.
  • SethDavisSethDavis Member Posts: 1,812
    edited August 2012
    @Avenger_teambg - Worked ^^, thanks

    also, when you said there was no cold damage were you saying that the effect should be changed from cold to magiccold as a bug or just pointing it out?
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    edited August 2012
    Just pointing it out as an "invalidation" of wand06 as a test object. I don't know why is there a separate magic cold damage, to be honest. But it is good to have the scorcher ice projectile fixed :)
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    @SethDavis: search for 'HIT_O6' in the code (near magic cold damage sound).
    Replace the O with a zero.
  • TanthalasTanthalas Member Posts: 6,738
    Confirmed Fixed

    For the sound thing and the visual effect.

    There's still the pending issue that Avenger_teambg mentioned.
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    Yeah, that was the original issue here :)
  • SethDavisSethDavis Member Posts: 1,812
    O_o how did you even know that was there? Fixed it, good catch ^^
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    SethDavis said:

    O_o how did you even know that was there? Fixed it, good catch ^^

    Haha. I learned reading IE disassembly 3 years ago. But we looked at the strings for 10 years.
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    Confirmed fixed - magic cold damage likely was changed to the correct sound (hit_06)
    Also for the bonus quest:
    1. SPSCORIC is the nice blue thing i donated.
    2. And wand of frost uses it! Oh fun, had to test in game too :)
  • lansounetlansounet Member Posts: 1,182
    Huh, isn't wand of frost supposed to cast something similar to Cone of Cold, instead of a cold damage scorcher?
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    Well, it says a column of ice in description.
  • lansounetlansounet Member Posts: 1,182
    Indeed but in BG2:ToB (at least, didn't check BG1) it is a fan-shaped cold attack. That works for me as a column of ice moving forward. This looks like nerfing potential
  • TanthalasTanthalas Member Posts: 6,738
    Confirmed Fixed

    Wand of Frost is now using hit_06
Sign In or Register to comment.

2024 Overhaul Games, a division of Beamdog. © 2024 Hasbro, Inc. All Rights Reserved. Baldur's Gate, Dungeons & Dragons, D&D, Forgotten Realms, Baldur's Gate, Wizards of the Coast and their logos are trademarks of Wizards of the Coast LLC in the U.S.A. and other countries, and are used with permission. Hasbro and its logo are trademarks of Hasbro, Inc. and are used with permission. © 1998 BioWare Corp. All Rights Reserved. BioWare, the BioWare Infinity Engine and the BioWare logo are trademarks of Bioware Corp. Black Isle Studios and the Black Isle Studios logo are trademarks of Interplay Entertainment Corp. Atari and the Atari logo are trademarks owned by Atari Interactive, Inc. All other trademarks are the property of their respective owners.