TobEx: 60 (0813)

DanBoulos

Current Behaviour:

Trigger Kit() uses the low short of the argument only, so both Kit(BARBARIAN [0x40000000]) Kit(0x80000000 [WILDMAGE]) will check for Kit(0)

Expected Behaviour:

Trigger Kit() uses the entire int, so Kit(BARBARIAN [0x40000000]) Kit(0x80000000 [WILDMAGE]) will check for 0x4000000 and 0x8000000, respectively

Revision:

Fix Kit() Trigger check to compare all kits

Wisp

Confirmed. However, WILDMAGE is missing from kit.ids (BARBARIAN is present).

CamDawg

With this fixed, do we still need all of the kit.ids shenanigans from BG2FP?

Wisp

@CamDawg
Nope. Kit checks work with the current values.

CamDawg

Sweet, though WILDMAGE is still missing from kit.ids in 0730.

SethDavis

checking this one now

Potentially fixed - MAGESCHOOL_WILDMAGE has been added

Wisp

@SethDavis
Eek? All existing uses expect it to be simply WILDMAGE.

SethDavis

@Wisp - Yeah, I'm finding that with something else as well *grumble grumble*

Will change it in a sec

Aaaaaaand it's changed

Avenger_teambg

kit.ids value update: http://forum.baldursgate.com/discussion/2781/bg2-kit-stuff-always-with-the-bugs

Avenger_teambg

Confirmed fixed
Well, all fixed except the blackguard capitalization (the link above has a patch), but i think while kit.ids used charisma as a dump stat, it still does its job.