Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Categories

Dark Dreams of Furiae - a new module for NWN:EE! Buy now
Attention, new and old users! Please read the new rules of conduct for the forums, and we hope you enjoy your stay!

[MOD] Jimfix - Ascension + SCS fixes, general tweaks - UPDATED FOR SCS v33

2»

Comments

  • Minsc2017Minsc2017 Member Posts: 34
    Follow up on my previous post: I was able to fix this problem. Now the text display effects are all written at the end of each spell header rather than the beginning.

    This means that all the non-stackable spells like Armor of Faith now correctly show the buff expirations. Jim, there may be a simpler edit to your existing expirations.tph to achieve the same thing; my version uses ADD_SPELL_EFFECT rather than your INSERT_EXPIRE_MESSAGE.

    If anyone wants to use this code, you can back up your existing jimfix expirations.tph, unzip mine and rename it to expirations.tph in the same file location.

    I've added a few extra spells in here as well which you can freely edit, delete, etc. I like to have Grease, Web, Cloudkill etc. expirations. Note that in the .tph file, they're added to the 'target the caster' section rather than the 'affects a target' section. You can move those around as desired. If you're Webbing 10 enemies, however, the dialogue box gets jammed up with expirations on each target AND the timers stack each time the enemy fails another save. Total mess. Keeping the expiration on 'caster' means you see a single timer counting down 30 seconds, 12 seconds, 6, etc. simply so you know when your spell is about to end.

  • BanananautBanananaut Member Posts: 25
    Sorry, I don't really check the forums anymore. I thought I would get emails if someone posted in this topic, but apparently that wasn't the case.

    @Cahir Sure, here is the English translation file. If you post a Polish version I can include it in the next release.

    @semaj577 Sorry, I'm not sure exactly what the issue is. Could you give a specific example of how to cause it? Might it be related to what Minsc2017 posted?

    @Minsc2017 Is this a version difference with the EEs? In the classic verison + Fixpack installs I've played, you're prevented from stacking Armor of Faith via a protection from spell effect (opcode 206). In this case, the notifications must appear before that effect, which is why I inserted them at the beginning.

    On the other hand, I have no idea why I decided to write my own function to insert the messages rather than just using ADD_SPELL_EFFECT, so I'll change that.

    Grond0ALIENMinsc2017JuliusBorisov
  • Minsc2017Minsc2017 Member Posts: 34
    edited June 2018
    @GrimJim
    GrimJim said:



    @Minsc2017 Is this a version difference with the EEs? In the classic verison + Fixpack installs I've played, you're prevented from stacking Armor of Faith via a protection from spell effect (opcode 206). In this case, the notifications must appear before that effect, which is why I inserted them at the beginning.

    On the other hand, I have no idea why I decided to write my own function to insert the messages rather than just using ADD_SPELL_EFFECT, so I'll change that.

    I've only modded on EE versions, but yes, it seems to be a widespread change to replace 206 functionality with 321.

    I'm guessing the reason is that both opcode 206 and 321 prevent stacking, but 321 allows you to cast a fresh spell and 'reset the clock' without needing to wait for your first casting to expire.

    I added a few other innates and spells to your list and I noticed my expirations weren't working for Berserker Enrage (spcl321). It seems to be the one and only spell that still uses opcode206 as the final effect. So it was preventing my EOF expirations from displaying.

    My kludgey solution for my own game is to start with a 'clean' copy of spcl321 with that opcode 206 removed. Then I run the expirations, and I've added this snippet to your code:


    /* put opcode 206 at end of Berserker Enrage SPCL321 */
    COPY_EXISTING_REGEXP GLOB ~SPCL321.spl~ ~override~
    PATCH_PRINT ~Add opcode 206 to end of %SOURCE_FILE%~
    LPF ADD_SPELL_EFFECT
    INT_VAR opcode = 206 target =1 timing=0 duration=60 parameter1=74011 resist_dispel=2
    STR_VAR resource=~SPCL321~ END
    BUT_ONLY_IF_IT_CHANGES

    Obviously if this were to be part of a mod, I'd need to first remove the opcode206 line as part of the code rather than manually, then do expirations, and then add back opcode 206 as shown here.

    For me, it was worth the little extra effort since I play permadeath games and knowing exactly when enrage is about to expire is one of the more crucial timers!

    Barbarian rage isn't set up this way, only berserker enrage is. I assume it's to reflect the 'cool down' penalties possessed by enrage but not rage. So you can do several overlapping barbarian rages, but not berserker enrages. I kind of like the difference since rage is 30 seconds and enrage is 60 seconds. Barbarian rage is shorter duration but you have less risk of getting caught by something during the cooldown...

    Post edited by Minsc2017 on
    Raduziel
  • BanananautBanananaut Member Posts: 25
    @Minsc2017 Thanks for checking that. It seems that the classic version doesn't even have opcode 321, so it must be an EE thing. Agreed that resetting the duration of buffs is a better solution than preventing you from recasting them. I want this mod to support both versions of the game, so I'll just put in a special case for enrage.

    Minsc2017JuliusBorisov
  • CrevsDaakCrevsDaak Member Posts: 7,152
    @GrimJim there seems to be a problem with Potions in my install; because of the way they work (opcode 146 on self casting a spell with the actual effects of the potion, but the op146 on the item itself has it's duration set to 0), your mod seems to be picking up the wrong duration and it marks that the potion expires immediately after drinking them.

    I suggest you run the spells that give these effects through the function that gives real spells their expiration notices, as this seems to be the easiest fix that doesn't involve meddling in two files at once, and needs the least amount of work as well, to produce the same results (only difference with the current method (if it worked) is that the effects will share the source like this, which isn't what's currently happening, but honestly, I think this is even better).

  • BanananautBanananaut Member Posts: 25
    @CrevsDaak Which mod make potions work that way?

  • CrevsDaakCrevsDaak Member Posts: 7,152
    @GrimJim I believe it's Item Revisions. Protection Scrolls also appear to be working like this. I'm not sure how other items with active abilities work, but I suppose it might be the same case for some of them (since some directly make use of Wizard spells, but some abilities do not have such a counterpart so it might not be the case).

  • ALIENALIEN Member Posts: 1,099
    edited September 2018
    @GrimJim Does you fixes for SCS are still needed for SCS 31?

    Post edited by ALIEN on
    Alonso
  • agrisagris Member Posts: 571
    edited December 2018
    n/t

    Post edited by agris on
  • AlonsoAlonso Member Posts: 781
    edited April 2019
    Kind of bumping this thread. Does anybody know if Jimfix works well with SCS v31 or SCS v32? I had a lot of problems with the combat log in my last installation (SCS v31), but I've no idea if they had something to do with Jimfix.

    Update: Looks like these problems came from elsewhere. After a full reinstallation they disappeared.

    Post edited by Alonso on
  • StefanOStefanO Member Posts: 342
    I'installed jimfix after SCS 31 and have no problems so far.

    Alonso
  • AlonsoAlonso Member Posts: 781
    I'm having a minor issue with the combat log. In a fight with a lich there is a message that says "Valarien: Death" (Valarien is the name of my protagonist). Jimfix is the only mod I use that affects the combat log, so I'm wondering if this might have something to do with Jimfix.

    Screenshot:
    oyfr70dr7ol3.png

  • DregothofTyrDregothofTyr Member Posts: 228
    Does anyone know if @GrimJim is still around?
    I want to install the buff and item timers on my BGEE and BG2EE installs. Can I just install it on top of a bunch of mods or does it need to go before anything? I have SCS v31, atweaks, bgtweaks, and a few other minor mods.

  • JuliusBorisovJuliusBorisov Member, Administrator, Moderator, Developer Posts: 20,962
    Alonso wrote: »
    I'm having a minor issue with the combat log. In a fight with a lich there is a message that says "Valarien: Death" (Valarien is the name of my protagonist). Jimfix is the only mod I use that affects the combat log, so I'm wondering if this might have something to do with Jimfix.

    Screenshot:
    oyfr70dr7ol3.png

    Was it a project image, maybe (who was killed)?
    Does anyone know if @GrimJim is still around?
    I want to install the buff and item timers on my BGEE and BG2EE installs. Can I just install it on top of a bunch of mods or does it need to go before anything? I have SCS v31, atweaks, bgtweaks, and a few other minor mods.

    I usually install it on top of everything.

  • AlonsoAlonso Member Posts: 781
    Was it a project image, maybe (who was killed)?
    No, I wasn't using any cloning spell.
    Does anyone know if @GrimJim is still around?
    You can check his last visit in his profile. It was in September, so unfortunately it looks like he's no longer active in this forum.

  • hugin7hugin7 Member Posts: 15
    I installed the buff expiration timers from https://forums.beamdog.com/discussion/70895/add-expiration-notifications-for-buffs-fixed-for-bg2ee-non-stackable-buffs and found that the Web spell notices come 6 seconds too late. Is this the correct version to install and if not, is there a better one?

  • ArkieArkie Member Posts: 6
    Hello, @Banananaut ! I've pulled request on mod's github with Russian translation.

  • BanananautBanananaut Member Posts: 25
    @Arkie Thank you. I've merged it in and created a new release with it added in.

  • AlonsoAlonso Member Posts: 781
    Banananaut wrote: »
    Help with translations is welcome. Just submit a pull request to the GitHub repository.
    I'll be happy to do the translation to Spanish if you're interested, but I don't know how that Github thing works.

  • BanananautBanananaut Member Posts: 25
    @Alonso If you upload a Spanish version of the setup.tra file here, I can take it from there. Thanks!

Sign In or Register to comment.