[(BG1, BG2) BUG] Shield Amulet redux (0813)

CamDawg

Per its description, the shield amulet is supposed to duplicate the effects of the spell 'shield'. Shield protects vs. magic missile, but the amulet lacks this protection. Fix:

// amulet of shield not protecting against MM
COPY_EXISTING ~amul15.itm~   ~override~
  LAUNCH_PATCH_FUNCTION ~ADD_ITEM_EFFECT~ INT_VAR
    opcode        = "206"        // protection from spell
    target        = "1"          // target self
    resist_dispel = "1"          // dispel/bypass MR
    duration      = "300"        // duration
    parameter1    = "0xffffffff" // strref -1
    type          = "3"          // only add to mag header
    STR_VAR resource = "spwi112"
    END
  LAUNCH_PATCH_FUNCTION ~ADD_ITEM_EFFECT~ INT_VAR
    opcode        = "139"   // display string
    target        = "1"     // target self
    resist_dispel = "1"     // dispel/bypass MR
    timing        = "1"     // instant/perm
    parameter1    = "14771" // strref
    type          = "3"     // only add to mag header
    END
  BUT_ONLY

SethDavis

Potentially fixed - @CamDawg 's fix has been used

Avenger_teambg

Confirmed fixed. Shield amulet protects from spell SPWI112.

Bhryaen

Confirmed Fixed:

With AMUL15 on but not activated, Magic Missile hits/ damages.
With AMUL15 on and activated, Magic Missile vanishes at its target.

CamDawg

@Bhryaen or @Tanthalas -- We need to re-open this one. @Wisp and @aVENGER noted and fixed in later versions of BG2FP, the amulet does not protect against traps that use magic missile as it's using a separate spell file. This can be applied to the existing amul15 in build 0803:

// amulet of shield not protecting against MM
COPY_EXISTING ~amul15.itm~   ~override~
  LAUNCH_PATCH_FUNCTION ~ADD_ITEM_EFFECT~ INT_VAR
    opcode        = "206"        // protection from spell
    target        = "1"          // target self
    resist_dispel = "1"          // dispel/bypass MR
    duration      = "300"        // duration
    parameter1    = "0xffffffff" // strref -1
    type          = "3"          // only add to mag header
    STR_VAR resource = "spwi003"
    END
  BUT_ONLY

Tanthalas

I'll tag @SethDavis so he takes a look at this one.

@CamDawg
I can't move the discussion because vanilla forums doesn't like my connection for some reason, but can't you edit your opening post and move the topic?

CamDawg

Right, forgot I can move my own topics. Thanks!

SethDavis

SethDavis said:

Potentially fixed - @CamDawg 's fix has been used

Behold my lazyness!

AndreaColombo

@CamDawg should probably get credited twice on the BG:EE manual: "Beta Tester" and "Chief Builder Of Code Seth Davis Should Have Developed In The First Place" =D

Avenger_teambg

AndreaColombo said:

@CamDawg should probably get credited twice on the BG:EE manual: "Beta Tester" and "Chief Builder Of Code Seth Davis Should Have Developed In The First Place" =D

Don't be so mean on Seth. Others took his (i mean Cam's) code like honey too
Besides, Seth is my favourite dev, he hunted down some really nasty crashers.

AndreaColombo

I was just kidding, Seth is awesome

SethDavis

That second title.... should also be written with a sparkling particle effect!

Avenger_teambg

confirmed fixed - shield amulet now protects against spwi003.
For ingame test: ar0505 (1186, 477) could be used.

Tanthalas

Confirmed Fixed in Build 0815

Used the same trap as Avenger_teambg to test this.