Skip to content

[(BG1, BG2) BUG] Shield Amulet redux (0813)

CamDawgCamDawg Member, Developer Posts: 3,438
edited August 2012 in Fixed
Per its description, the shield amulet is supposed to duplicate the effects of the spell 'shield'. Shield protects vs. magic missile, but the amulet lacks this protection. Fix:


// amulet of shield not protecting against MM
COPY_EXISTING ~amul15.itm~ ~override~
LAUNCH_PATCH_FUNCTION ~ADD_ITEM_EFFECT~ INT_VAR
opcode = "206" // protection from spell
target = "1" // target self
resist_dispel = "1" // dispel/bypass MR
duration = "300" // duration
parameter1 = "0xffffffff" // strref -1
type = "3" // only add to mag header
STR_VAR resource = "spwi112"
END
LAUNCH_PATCH_FUNCTION ~ADD_ITEM_EFFECT~ INT_VAR
opcode = "139" // display string
target = "1" // target self
resist_dispel = "1" // dispel/bypass MR
timing = "1" // instant/perm
parameter1 = "14771" // strref
type = "3" // only add to mag header
END
BUT_ONLY
Post edited by Bhryaen on
AndreaColombo

Comments

  • SethDavisSethDavis Member Posts: 1,812
    Potentially fixed - @CamDawg 's fix has been used
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    Confirmed fixed. Shield amulet protects from spell SPWI112.
  • BhryaenBhryaen Member Posts: 2,874
    Confirmed Fixed:

    With AMUL15 on but not activated, Magic Missile hits/ damages.
    With AMUL15 on and activated, Magic Missile vanishes at its target.
  • CamDawgCamDawg Member, Developer Posts: 3,438
    @Bhryaen or @Tanthalas -- We need to re-open this one. @Wisp and @aVENGER noted and fixed in later versions of BG2FP, the amulet does not protect against traps that use magic missile as it's using a separate spell file. This can be applied to the existing amul15 in build 0803:
    // amulet of shield not protecting against MM
    COPY_EXISTING ~amul15.itm~ ~override~
    LAUNCH_PATCH_FUNCTION ~ADD_ITEM_EFFECT~ INT_VAR
    opcode = "206" // protection from spell
    target = "1" // target self
    resist_dispel = "1" // dispel/bypass MR
    duration = "300" // duration
    parameter1 = "0xffffffff" // strref -1
    type = "3" // only add to mag header
    STR_VAR resource = "spwi003"
    END
    BUT_ONLY
  • TanthalasTanthalas Member Posts: 6,738
    I'll tag @SethDavis so he takes a look at this one.

    @CamDawg
    I can't move the discussion because vanilla forums doesn't like my connection for some reason, but can't you edit your opening post and move the topic?
  • CamDawgCamDawg Member, Developer Posts: 3,438
    Right, forgot I can move my own topics. Thanks!
  • SethDavisSethDavis Member Posts: 1,812
    SethDavis said:

    Potentially fixed - @CamDawg 's fix has been used

    Behold my lazyness!
  • AndreaColomboAndreaColombo Member Posts: 5,524
    @CamDawg should probably get credited twice on the BG:EE manual: "Beta Tester" and "Chief Builder Of Code Seth Davis Should Have Developed In The First Place" =D
    SethDavis
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    edited August 2012

    @CamDawg should probably get credited twice on the BG:EE manual: "Beta Tester" and "Chief Builder Of Code Seth Davis Should Have Developed In The First Place" =D

    Don't be so mean on Seth. Others took his (i mean Cam's) code like honey too :)
    Besides, Seth is my favourite dev, he hunted down some really nasty crashers.
  • AndreaColomboAndreaColombo Member Posts: 5,524
    I was just kidding, Seth is awesome :)
    Avenger_teambgTanthalas
  • SethDavisSethDavis Member Posts: 1,812
    That second title.... should also be written with a sparkling particle effect!
  • Avenger_teambgAvenger_teambg Member, Developer Posts: 5,862
    confirmed fixed - shield amulet now protects against spwi003.
    For ingame test: ar0505 (1186, 477) could be used.
  • TanthalasTanthalas Member Posts: 6,738
    Confirmed Fixed in Build 0815

    Used the same trap as Avenger_teambg to test this.
Sign In or Register to comment.