Can't cure disease!

Tresset

Expected behavior: Spells such as "cure disease" and "neutralize poison" should completely cure and remove the effects of a Ghast's/Greater Ghoul's THAC0 lowering nausea disease.
Current behavior: Disease curing spells will ONLY remove the "diseased" portrait icon for the condition. The THAC0 is not returned to normal until the disease wears off.

As this is one of like two or three diseases that appear in the game it would be nice to have the spells work as described to cure it.

Edit: Further research reveals that the same is true for the wraith spiders strength drain disease. I am starting to think that these spells do not work at all on any disease. This needs fixing.

[Deleted User]

The user and all related content has been deleted.

Tresset

@Bhaaldog From what I heard it didn't work at all in vanilla. Something about "state diseased" being "broken". Not really sure what that means though. Anyway it is likely a bug that originated in BG2. I think @CamDawg had it fixed in his fixpack though so I'm not sure how it got broken again.

CamDawg

Nah, STATE_DISEASED is a separate issue. Somewhere along the way S_D was repurposed by the original devs and actually tracks whether a creature is activated or not. There are still other ways to determine if a creature is diseased (i.e. the third party Detectable Spells) so it's not really a problem; the lack of it working affects nothing in BG/BG2/BGEE.

The problem here is that curing disease, at the moment, only removes the disease opcode (i.e. damage only), a few other common disease effects (blindness, feeblemind, deafness), and their associated portrait icons. Since THAC0 changes (good and bad) are caused by a slew of spells/items/abilities you can't 'cure' the THAC0 penalty without potentially affecting a lot of stuff it shouldn't.

The good news here is that we've introduced a new opcode in the local beta builds that lets us selectively nuke effects based upon their source, an incredibly useful ability that was in IWD. This could potentially let us address this, as well as other minor bugs such as Remove Fear not removing the little spinny animations from Horror. It could also allow us to have much more sensible spell stacking--e.g. right now if you cast Armor of Faith when it's already active you just waste the spell and it expires when the original spell would expire. With the new opcode, you could re-cast it and essentially reset the duration without wasting the spell or illegally stacking them.