Warrior's level-based APR incorrectly being applied

kjeron

[Windows / Beaddog / Unmodded]

Observed: Any class flagged "GETS_PROF_APR" in "CLSWPBON.2da" is getting the level-based APR determined through "WSPATCK.2da" even when they equip weapons they do not have proficiency with.
Expected: They should only receive the extra APR if they are at least proficient with the weapon. BG1EE and IWDEE both still function this way.

Reproduction(BG2EE)v1.3:
- Start new ToB game with Abdel Pre-gen.
- Abdel is a level 7 fighter, with 5 pips in longsword.
- Adbel has 3/2 APR with the quarterstaff he starts with. 1 base + 1/2 from "WSPATCK.2da".
- Pull and equip Varscona from the Bag of Holding.
- Adbel has 5/2 APR with Varscaona, +1 from Grandmastery, +1/2 from "WSPATCK.2da".

Reproduction(BG1EE)v1.3:
- Start new ToB game with Abdel Pre-gen.
- Console SetCurrentXP("80000")
- Level up, put proficiency points anywhere except quarterstaff.
- Abdel now is a level 7 fighter, with 2-4 pips in longsword.
- Adbel has 1 APR with the quarterstaff he starts with.
- Consoel and equip Varscona, CreateItem("sw1h60").
- Adbel has 2 APR with Varscaona, +1/2 from Specialization, +1/2 from "WSPATCK.2da".

Reproduction(IWDEE)v1.4:
- Start new HoW game with default party.
- Gorris is a level 10 berserker(fighter), with 5 pips in two-handed sword.
- Gorris has 3 APR with the two-handed sword he starts with, +3/2 from Grandmastery, +1/2 from "WSPATCK.2da".
- Equip Baern's Morningstar on Gorris.
- Gorris has 1 APR with the Morningstar.

Gate70

Hi
I believe this is intentional (internal reference is 11025).

[Deleted User]

The user and all related content has been deleted.

Gallowglass

Gate70 said:

I believe this is intentional (internal reference is 11025).

But is it intentional that it's inconsistent between BG1ee and BG2ee? Whichever way the devs intend it to work, surely that ought to be the same in both games?

Dee

Based on the resource files, IWD:EE and BG:EE should be functioning the same way as BGII:EE with regard to non-proficient attacks per round (i.e. you get the bonus attacks for your level regardless of your proficiency).

If that's not the case for you, we'll need to dig into whether or not your installation has been modded to change WSPATCK.2da in any way.

kjeron

Dee said:

If that's not the case for you, we'll need to dig into whether or not your installation has been modded to change WSPATCK.2da in any way.

IWDEE and BGEE are functioning as I described without mods, they prioritize non-proficiency over WSPATCK.

Dee

Did some digging.

IWD:EE and BG:EE (in their current state) ignore WSPATCK.2da if the character's not proficient with their current weapon (which was a bug; if WSPATCK says a character should get an extra attack with no proficiency, they should get an extra attack).

BGII:EE implemented code that removes this restriction, but that code has not yet populated over to BG:EE and IWD:EE. So the BGII:EE behavior is working correctly, and eventually BG:EE and IWD:EE will work the same way.

As for how it worked in PnP, some quick research into our AD&D library revealed nothing that says proficiency is a requirement to receive a warrior's bonus attacks. So the fixed behavior in BGII:EE is actually closer to PnP than the old (broken) behavior.

And of course, if you don't like the new behavior, it's now possible to change it by modifying WSPATCK.2da, which wasn't possible before.